Fix trimming of padding in table cells#405
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=========================================
Coverage 95.67% 95.67%
Complexity 682 682
=========================================
Files 45 45
Lines 2010 2012 +2
=========================================
+ Hits 1923 1925 +2
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/Lexer.php
Outdated
There was a problem hiding this comment.
Should we rename the shouldSupportNewlineEscapeSequenceInTableCell flag, since that's now covering two slightly different variances?
There was a problem hiding this comment.
shouldSupportNewlineEscapeSequenceAndUnicodePaddingInTableCell would be the name covering all differences with the legacy mode, but this is crazy long.
There was a problem hiding this comment.
It is indeed. Maybe we go more vague - shouldUseNewTableCellParsing() or something? It's not a huge deal, the methods are only really for our benefit, but it might be easier to understand in future with a name that's not explicit than one that is explicit but incomplete?
There was a problem hiding this comment.
I renamed the method with your suggestion.
stof
force-pushed
the
fix_cell_trimming
branch
from
81bb295 to
c8399ab
Compare
This trims Unicode spaces (as done upstream) without removing newlines produces by escape sequences.
stof
force-pushed
the
fix_cell_trimming
branch
from
c8399ab to
c5d218f
Compare
2 participants
This trims Unicode spaces (as done upstream) without removing newlines produces by escape sequences.
Closes #395
This does not change the legacy mode (the
parseTableCellprivate method is not used by the legacy parsing mode).